This revision was automatically updated to reflect the committed changes.
Closed by commit rL313018: [ARM] Option for reading thread pointer from
coprocessor register (authored by spetrovic).
Changed prior to commit:
https://reviews.llvm.org/D34878?vs=114618=114792#toc
Repository:
rL LLVM
kristof.beyls added a comment.
Still LGTM; please commit.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic updated this revision to Diff 114618.
spetrovic added a comment.
Indentations fixed.
https://reviews.llvm.org/D34878
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/ARM.cpp
spetrovic added a comment.
Thanks for the review! I will check indentations with clang format.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kristof.beyls accepted this revision.
kristof.beyls added a comment.
This revision is now accepted and ready to land.
Thanks Strahinja!
I thought that some indentations looked a bit strange, so I'd just still check
that clang-format formats your changes the same way.
Otherwise LGTM!
spetrovic updated this revision to Diff 114582.
https://reviews.llvm.org/D34878
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/ARM.cpp
lib/Driver/ToolChains/Arch/ARM.h
spetrovic added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:149-150
+else
+ D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args);
+ }
+ return ReadTPMode::Soft;
kristof.beyls wrote:
> a return ReadTPMode::Invalid is missing
kristof.beyls added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:137
+ const Driver = TC.getDriver();
+ arm::ReadTPMode ThreadPointer = ReadTPMode::Invalid;
+ if (Arg *A =
With the new version of the code, there's no need to have a
spetrovic added a comment.
Comments addressed.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic updated this revision to Diff 114573.
https://reviews.llvm.org/D34878
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/ARM.cpp
lib/Driver/ToolChains/Arch/ARM.h
kristof.beyls added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:145-146
+ // choose soft mode.
+ if (ThreadPointer == ReadTPMode::Invalid)
+ThreadPointer = ReadTPMode::Soft;
+ return ThreadPointer;
spetrovic wrote:
> kristof.beyls
spetrovic updated this revision to Diff 114329.
spetrovic marked 3 inline comments as done.
https://reviews.llvm.org/D34878
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/ARM.cpp
spetrovic marked 3 inline comments as done.
spetrovic added inline comments.
Comment at: include/clang/Driver/Options.td:1664-1665
HelpText<"Allow generation of data access to code sections (ARM only)">;
+def mtp_mode_EQ : Joined<["-"], "mtp=">, Group,
Values<"soft, cp15">,
kristof.beyls added inline comments.
Comment at: include/clang/Driver/Options.td:1664-1665
HelpText<"Allow generation of data access to code sections (ARM only)">;
+def mtp_mode_EQ : Joined<["-"], "mtp=">, Group,
Values<"soft, cp15">,
+ HelpText<"Read thread pointer from
spetrovic added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:136
+if (ThreadPointer == ReadTPMode::Invalid &&
+!StringRef(A->getValue()).empty()) {
+ D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args);
bruno wrote:
>
spetrovic updated this revision to Diff 109571.
spetrovic marked 2 inline comments as done.
Repository:
rL LLVM
https://reviews.llvm.org/D34878
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
bruno added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:136
+if (ThreadPointer == ReadTPMode::Invalid &&
+!StringRef(A->getValue()).empty()) {
+ D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args);
What happens if you
spetrovic added a comment.
Comments addressed.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic updated this revision to Diff 109088.
https://reviews.llvm.org/D34878
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/ARM.cpp
lib/Driver/ToolChains/Arch/ARM.h
bruno added a comment.
If there's a precedence for a flag name there, it's nice to be compatible here.
You don't necessarily need to use the same name as the backend.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
spetrovic added a comment.
Hi Bruno,
Yes, GCC has similar option (-mtp=soft/hard), but name is not same. I put the
same option name as in backend (https://reviews.llvm.org/D34408).
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
bruno added a comment.
Hi Strahinja,
Does GCC already has a similar option? If so, does this share the same name?
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
spetrovic added a comment.
ping
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic added a comment.
ping
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spetrovic created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
This patch enables option for reading thread pointer directly from coprocessor
register (-mread-tp-hard). This option is supported in llc also (
https://reviews.llvm.org/D34408 ).
26 matches
Mail list logo
