Re: [PATCH] D34896: Enable the new PM + SamlePGO + ThinLTO testing.

2017-07-11 Thread David Blaikie via cfe-commits
On Mon, Jul 10, 2017 at 10:58 AM Dehao Chen wrote: > This test was originally added in https://reviews.llvm.org/D34721 with > clang change. It's kind of dup of the previous test > (-check-prefix=SAMPLEPGO) in terms of testing the clang bits. But we > want to make sure the

Re: [PATCH] D34896: Enable the new PM + SamlePGO + ThinLTO testing.

2017-07-10 Thread Dehao Chen via cfe-commits
This test was originally added in https://reviews.llvm.org/D34721 with clang change. It's kind of dup of the previous test (-check-prefix=SAMPLEPGO) in terms of testing the clang bits. But we want to make sure the new PM has the expected behavior. I guess it would be acceptable to remove one of

Re: [PATCH] D34896: Enable the new PM + SamlePGO + ThinLTO testing.

2017-07-10 Thread David Blaikie via cfe-commits
Does this test any code in Clang? (given the test is being committed without any change in Clang, I'm guessing maybe not) - perhaps this test doesn't belong in Clang's test suite? Looks like changes/functionality in LTOPreLinkDefaultPipeline are tested in test/Other/new-pm-thinlto-defaults.ll at

[PATCH] D34896: Enable the new PM + SamlePGO + ThinLTO testing.

2017-06-30 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34896: Enable the new PM + SamlePGO + ThinLTO testing.

2017-06-30 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh created this revision. Herald added subscribers: eraman, inglorion, mehdi_amini, sanjoy. This patch should be enabled after https://reviews.llvm.org/D34895 https://reviews.llvm.org/D34896 Files: test/CodeGen/pgo-sample-thinlto-summary.c Index: