Re: [PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

On 30 August 2017 at 11:52, Boris Kolpackov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Victor Leschuk writes: > > > Hello Boris, looks like this revision broke tests on our win10 builder: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_ >

Re: [PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

Victor Leschuk writes: > Hello Boris, looks like this revision broke tests on our win10 builder: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11760 > > Clang :: CXX/modules-ts/basic/basic.link/module-declaration.cpp > >

Re: [PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

Hello Boris, looks like this revision broke tests on our win10 builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11760 Clang :: CXX/modules-ts/basic/basic.link/module-declaration.cpp I had to revert this revision. Could you please take a look?

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rL312105: [modules] Add ability to specify module name to module file mapping (authored by borisk). Changed prior to commit: https://reviews.llvm.org/D35020?vs=111826=113207#toc Repository: rL LLVM

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris marked 2 inline comments as done. boris added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:986 +if (Val.find('=') == StringRef::npos) + Opts.ExtraDeps.push_back(Val); + } rsmith wrote: > Does a module file specified via

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Only typographical nits and post-commit suggestions, so please go ahead. Thanks! Comment at: include/clang/Serialization/ModuleManager.h:63 + /// \brief Preprocessor's

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. https://reviews.llvm.org/D35020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added inline comments. Comment at: lib/Serialization/ASTReader.cpp:4145-4146 +// by-name lookup. +if (Type == MK_PrebuiltModule || Type == MK_ExplicitModule) + ModuleMgr.registerPrebuilt(F); break; rsmith wrote: > I'm

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris marked 6 inline comments as done. boris added a comment. I've marked as "done" items that I have resolved in my local revision (not yet uploaded) and have added one comment for further feedback. Comment at: lib/Frontend/CompilerInvocation.cpp:982 +StringRef Val =

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

rsmith added inline comments. Comment at: docs/ClangCommandLineReference.rst:3-4 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by hand!!

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. https://reviews.llvm.org/D35020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. https://reviews.llvm.org/D35020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. FWIW, I went ahead and implemented this functionality in GCC. It has been merged into its c++-modules branch. https://reviews.llvm.org/D35020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. I am holding off on proposing the same functionality to GCC because I want to make sure the command line interface is the same for both compilers (GCC has less baggage in this area, option-name-wise). So confirming that at least the naming/semantics are acceptable

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris updated this revision to Diff 107017. boris added a comment. Rebase on latest HEAD. https://reviews.llvm.org/D35020 Files: docs/ClangCommandLineReference.rst docs/Modules.rst include/clang/Driver/Options.td include/clang/Lex/HeaderSearch.h

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. https://reviews.llvm.org/D35020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris updated this revision to Diff 106041. boris added a comment. Rebase on latest HEAD. https://reviews.llvm.org/D35020 Files: docs/ClangCommandLineReference.rst docs/Modules.rst include/clang/Driver/Options.td include/clang/Lex/HeaderSearch.h

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris created this revision. Extend the -fmodule-file option to support the [=] value format. If the name is omitted, then the old semantics is preserved (the module file is loaded whether needed or not). If the name is specified, then the mapping is treated as just another prebuilt module search