EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D35174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bcraig updated this revision to Diff 105845.
bcraig edited the summary of this revision.
bcraig added a comment.
Switched to static consts
https://reviews.llvm.org/D35174
Files:
include/string
Index: include/string
===
---
EricWF added a comment.
Maybe using a static const variable instead of an enum would work better?
`__long_mask` should never actually be ODR used so a definition for it should
never actually be needed.
https://reviews.llvm.org/D35174
___
bcraig created this revision.
When using LIBCXX_ABI_UNSTABLE=YES, clang-cl gave the following warning:
P:\llvm_master\src\llvm\projects\libcxx\include\string(683,51):
warning: enumerator value is not representable in the underlying type
'int' [-Wmicrosoft-enum-value]
Fixed by providing a
