This revision was automatically updated to reflect the committed changes.
Closed by commit rL307809: [clang] buildFixItInsertionLine should use Hints of
the same FID and LineNo (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35230?vs=105937=106240#toc
Repository:
rL
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you for the fix!
https://reviews.llvm.org/D35230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
chh added inline comments.
Comment at: lib/Frontend/TextDiagnostic.cpp:1109-1110
- } else {
-FixItInsertionLine.clear();
-break;
}
chh wrote:
> alexfh wrote:
> > Did you figure out why the old code used to give up here? Why does your
chh added inline comments.
Comment at: lib/Frontend/TextDiagnostic.cpp:1109-1110
- } else {
-FixItInsertionLine.clear();
-break;
}
alexfh wrote:
> Did you figure out why the old code used to give up here? Why does your code
> just
alexfh added inline comments.
Comment at: lib/Frontend/TextDiagnostic.cpp:1109-1110
- } else {
-FixItInsertionLine.clear();
-break;
}
Did you figure out why the old code used to give up here? Why does your code
just continue?
chh added a comment.
See https://reviews.llvm.org/D35225 for a test case.
https://reviews.llvm.org/D35230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh created this revision.
Fix bug https://bugs.llvm.org/show_bug.cgi?id=33734
https://reviews.llvm.org/D35230
Files:
lib/Frontend/TextDiagnostic.cpp
Index: lib/Frontend/TextDiagnostic.cpp
===
---
