This revision was automatically updated to reflect the committed changes.
Closed by commit rL311028: [clang-tidy] Add a close-on-exec check on
epoll_create1() in Android module. (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35365?vs=110752=111385#toc
Repository:
rL
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D35365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yawanng updated this revision to Diff 110752.
https://reviews.llvm.org/D35365
Files:
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/CloexecEpollCreate1Check.cpp
clang-tidy/android/CloexecEpollCreate1Check.h
docs/ReleaseNotes.rst
yawanng updated this revision to Diff 110652.
https://reviews.llvm.org/D35365
Files:
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/CloexecEpollCreate1Check.cpp
clang-tidy/android/CloexecEpollCreate1Check.h
docs/ReleaseNotes.rst
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
See the comment on https://reviews.llvm.org/D35372.
https://reviews.llvm.org/D35365
___
cfe-commits mailing list
yawanng updated this revision to Diff 106523.
yawanng marked 2 inline comments as done.
https://reviews.llvm.org/D35365
Files:
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/CloexecEpollCreate1Check.cpp
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/android/CloexecEpollCreate1Check.cpp:21
+
+static constexpr const char *EPOLL_CLOEXEC = "EPOLL_CLOEXEC";
+
Please make this declaration consent across all checks. In some checks it
declared inside
