This revision was automatically updated to reflect the committed changes.
Closed by commit rL308398: Debug Info: Add a file: field to DIImportedEntity.
(authored by adrian).
Changed prior to commit:
https://reviews.llvm.org/D35583?vs=107180=107211#toc
Repository:
rL LLVM
aprantl added inline comments.
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1684
+ HasFile ? getMDOrNull(Record[6]) : nullptr,
+ HasFile ? Record[4] : 0, getMDString(Record[5]))),
NextMetadataNo);
probinson added a comment.
Sweet. I don't have the chops to understand the Objective-C test but otherwise
LGTM.
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1684
+ HasFile ? getMDOrNull(Record[6]) : nullptr,
+ HasFile ?
aprantl updated this revision to Diff 107180.
aprantl added a comment.
Forgot to git-add new clang test case input files.
https://reviews.llvm.org/D35583
Files:
include/llvm/IR/DIBuilder.h
include/llvm/IR/DebugInfoMetadata.h
lib/AsmParser/LLParser.cpp
aprantl added a comment.
Note that this review contains also the corresponding clang changes in the
tools/ directory.
Repository:
rL LLVM
https://reviews.llvm.org/D35583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aprantl created this revision.
Herald added subscribers: eraman, mehdi_amini.
DIImportedEntity has a line number, but not a file field. To determine the
decl_line/decl_file we combine the line number from the DIImportedEntity with
the file from the DIImportedEntity's scope. This does not work
