[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

2017-07-24 Thread Nico Weber via Phabricator via cfe-commits
thakis closed this revision. thakis added a comment. r308897. https://reviews.llvm.org/D35757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

2017-07-24 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D35757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

2017-07-21 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. From what I understand, _MSC_VER changes with each 2017 update. https://reviews.llvm.org/D35757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

2017-07-21 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added inline comments. Comment at: lib/AST/StmtProfile.cpp:1367 +#if defined(_MSC_VER) && _MSC_VER == 1911 +// Work around https://developercommunity.visualstudio.com/content/problem/84002/clang-cl-when-built-with-vc-2017-crashes-cause-vc.html Is it

[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

2017-07-21 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. MSVC2017 update 3 produces a clang that crashes when compiling clang. Disabling optimizations for StmtProfiler::VisitCXXOperatorCallExpr() makes the crash go away. Patch from Bruce Dawson ! https://reviews.llvm.org/D35757 Files: