[PATCH] D35863: Use the allocator's pointers for deallocation in `std::list`

2017-08-03 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone updated this revision to Diff 109678. Quuxplusone added a comment. I've updated https://reviews.llvm.org/D35863 to be actually correct AFAICT from my local testing; but I'm not sure what's the most appropriate way to get "fancy allocator" tests into libcxx's test suite. The way I did

[PATCH] D35863: Use the allocator's pointers for deallocation in `std::list`

2017-08-02 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. First, this patch would need tests before continuing, Could you please them? The list tests live under `test/std/containers/sequences/list`. Let me know if you have any questions or

[PATCH] D35863: Use the allocator's pointers for deallocation in `std::list`

2017-07-25 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone created this revision. `pointer_traits::to_pointer(r)` is not required to return a deallocatable pointer; indeed generally it *cannot* determine a deallocatable representation without help from the allocator. Therefore, we must not rely on representations derived from `to_pointer` w