[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309696: [clangd] Rewrote AST and Preamble management. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D36133 Files: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tool

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. ship it! https://reviews.llvm.org/D36133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:113 + /// queue. The request will be run on a separate thread. + template void addToFront(Func &&F, Args &&... As); + /// Add a new request to run function

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

ilya-biryukov updated this revision to Diff 109124. ilya-biryukov added a comment. Addressed review comments. - Moved implementations of template function to header. - Fixed a typo. https://reviews.llvm.org/D36133 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

ilya-biryukov updated this revision to Diff 109091. ilya-biryukov added a comment. - Fixed a bug that caused CppFiles to be deleted while used. https://reviews.llvm.org/D36133 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/ClangdU

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

bkramer added inline comments. Comment at: clangd/ClangdServer.h:113 + /// queue. The request will be run on a separate thread. + template void addToFront(Func &&F, Args &&... As); + /// Add a new request to run function \p F with args \p As to the end of the ---

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

ilya-biryukov added a comment. I also want to rename ClangdUnit and ClangdUnitStore accordingly, but will do that in a separate commit so that git-svn correctly detects the renames (i.e. don't want file contents changes). https://reviews.llvm.org/D36133 _

[PATCH] D36133: [clangd] Rewrote AST and Preamble management.

ilya-biryukov created this revision. The new implementation allows code completion that never waits for AST. https://reviews.llvm.org/D36133 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/ClangdUnitStore.cpp clangd/ClangdUnitSto