This revision was automatically updated to reflect the committed changes.
Closed by commit rL311292: [clang-diff] Improve and test getNodeValue (authored
by krobelus).
Changed prior to commit:
https://reviews.llvm.org/D36186?vs=110952=111893#toc
Repository:
rL LLVM
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Perfect, thanks!
https://reviews.llvm.org/D36186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
johannes updated this revision to Diff 110952.
johannes added a comment.
add test for delegating initializer and unwritten initializer
https://reviews.llvm.org/D36186
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-ast.cpp
arphaman added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:428
+Value += getRelativeName(V) + "(" + V->getType().getAsString(TypePP) + ")";
+if (auto *C = dyn_cast(D)) {
+ for (auto *Init : C->inits()) {
It looks like you're doing a
johannes added inline comments.
Comment at: test/Tooling/clang-diff-ast.cpp:32
+
+// CHECK: TypedefDecl: nat;unsigned int;(
+typedef unsigned nat;
klimek wrote:
> For my curiosity: why are there semicolons here? Is the format documented
> somewhere?
To avoid
johannes updated this revision to Diff 109426.
johannes added a comment.
renamse, NFC
https://reviews.llvm.org/D36186
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-ast.cpp
test/Tooling/clang-diff-basic.cpp
johannes updated this revision to Diff 109425.
johannes added a comment.
NFC renames
https://reviews.llvm.org/D36186
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-ast.cpp
test/Tooling/clang-diff-basic.cpp
