danielmarjamaki abandoned this revision.
danielmarjamaki added a comment.
Herald added subscribers: llvm-commits, a.sidorin, rnkovacs.
I will not continue working on this. Feel free to take over the patch or write
a new patch.
Repository:
rL LLVM
https://reviews.llvm.org/D36471
__
danielmarjamaki updated this revision to Diff 121726.
danielmarjamaki added a comment.
Herald added a subscriber: szepet.
I have updated the patch so it uses evalBinOpNN. This seems to work properly.
I have a number of TODOs in the test cases that should be fixed. Truncations
are not handled pro
xazax.hun added a subscriber: NoQ.
xazax.hun added a comment.
I think this change is very useful but it is also important to get these
changes right.
I think one of the main reason you did not get review comments yet is that it
is not easy to verify that these changes are sound.
In general, the
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D36471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D36471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D36471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D36471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki updated this revision to Diff 113969.
danielmarjamaki added a comment.
minor code cleanup
Repository:
rL LLVM
https://reviews.llvm.org/D36471
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
lib/StaticAnalyzer/Core/ExprEngineC.cpp
lib/StaticAna
danielmarjamaki added a comment.
Should evalAPSInt() have machinery to do standard sign/type promotions? I
suggest that I add one more argument `bool promote = false`, do you think that
sounds good?
Repository:
rL LLVM
https://reviews.llvm.org/D36471
_
danielmarjamaki updated this revision to Diff 110378.
danielmarjamaki added a comment.
Refactoring, use BasicValueFactory::evalAPSInt
Repository:
rL LLVM
https://reviews.llvm.org/D36471
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
lib/StaticAnalyzer/Core/Exp
danielmarjamaki added a comment.
In https://reviews.llvm.org/D36471#835410, @xazax.hun wrote:
> Can't you reuse somehow some machinery already available to evaluate the
> arithmetic operators? Those should already handle most of your TODOs and
> overflows.
Sounds good.. I have not seen that m
danielmarjamaki updated this revision to Diff 110220.
danielmarjamaki added a comment.
A minor code cleanup. No functional change.
Repository:
rL LLVM
https://reviews.llvm.org/D36471
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
lib/StaticAnalyzer/Core/ExprEn
xazax.hun added a comment.
Can't you reuse somehow some machinery already available to evaluate the
arithmetic operators? Those should already handle most of your TODOs and
overflows.
Repository:
rL LLVM
https://reviews.llvm.org/D36471
___
cfe-
danielmarjamaki created this revision.
In the code below the division result should be a value between 5 and 25.
if (a >= 10 && a <= 50) {
int b = a / 2;
}
This patch will calculate results for additions, subtractions and divisions.
I intentionally do not try to handle all possible case
14 matches
Mail list logo
