This revision was automatically updated to reflect the committed changes.
Closed by commit rL311037: Use the file name from linemarker for debug info if
an input is preprocessed… (authored by twoh).
Repository:
rL LLVM
https://reviews.llvm.org/D36474
Files:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D36474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
twoh added a comment.
Ping. Thanks!
https://reviews.llvm.org/D36474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh updated this revision to Diff 110237.
twoh added a comment.
Addressing dblaikie's comments. Thanks!
https://reviews.llvm.org/D36474
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGen/debug-info-preprocessed-file.i
Index: test/CodeGen/debug-info-preprocessed-file.i
dblaikie added a comment.
Looks plausible (not sure how nice it is to use the llvm::Module itself to
communicate the file name to this bit of logic - I'll leave that to Richard
Smith to judge, I think)
Comment at: test/CodeGen/debug-info-preprocessed-file.i:10
+// RUN:
twoh updated this revision to Diff 110230.
twoh added a comment.
Relocate.
https://reviews.llvm.org/D36474
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGen/debug-info-preprocessed-file.i
Index: test/CodeGen/debug-info-preprocessed-file.i
twoh created this revision.
Herald added a subscriber: aprantl.
Even in the case of the input file is a preprocessed source, clang uses the
file name of the preprocesses source for debug info (DW_AT_name attribute for
DW_TAG_compile_unit). However, gcc uses the file name specified in the first
