This revision was automatically updated to reflect the committed changes.
Closed by commit rL311984: [clang-tidy] Fix 'misc-misplaced-widening-cast'
assertion error. (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D36670?vs=110940=113026#toc
Repository:
rL
alexfh accepted this revision.
alexfh added a comment.
LG. Thank you for the fix!
Comment at: test/clang-tidy/misc-misplaced-widening-cast-explicit-only.cpp:63
+ enum Type {};
+ static char *m_fn1() { char p = (Type)( - m_fn1()); }
+};
xazax.hun wrote:
>
xazax.hun added inline comments.
Comment at: test/clang-tidy/misc-misplaced-widening-cast-explicit-only.cpp:63
+ enum Type {};
+ static char *m_fn1() { char p = (Type)( - m_fn1()); }
+};
Isn't this testcase a bit overcomplicated to demonstrate the issue?
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D36670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
danielmarjamaki added a comment.
LGTM. I let others approve this.
Repository:
rL LLVM
https://reviews.llvm.org/D36670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AndersRonnholm created this revision.
AndersRonnholm added a project: clang-tools-extra.
Fixes assert reported in https://bugs.llvm.org/show_bug.cgi?id=33660
Repository:
rL LLVM
https://reviews.llvm.org/D36670
Files:
clang-tidy/misc/MisplacedWideningCastCheck.cpp
