This revision was automatically updated to reflect the committed changes.
Closed by commit rL313284: [libc++] Prevent stale site configuration headers
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D36720?vs=111096=115250#toc
Repository:
rL LLVM
smeenai added inline comments.
Comment at: CMakeLists.txt:633
+ if (EXISTS "${site_config_path}")
+file(REMOVE "${site_config_path}")
+ endif()
EricWF wrote:
> Maybe print a warning or a message here? While it seems useful to
> re-configure and remove the
EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.
Comment at: CMakeLists.txt:633
+ if (EXISTS "${site_config_path}")
+file(REMOVE "${site_config_path}")
+ endif()
Maybe print a warning or a
mclow.lists added a comment.
This looks reasonable to me.
https://reviews.llvm.org/D36720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Ping.
https://reviews.llvm.org/D36720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai created this revision.
Herald added a subscriber: mgorny.
If we define cmake macros that require a site config, and then undefine
all such macros, a stale site config header will be left behind.
Explicitly delete any generate site config if we don't need one to avoid
this.
