[PATCH] D36761: [clang-tidy] Use CloexecCheck as base class.

2017-08-16 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL311020: [clang-tidy] Use CloexecCheck as base class. (authored by chh). Changed prior to commit: https://reviews.llvm.org/D36761?vs=111372=111373#toc Repository: rL LLVM

[PATCH] D36761: [clang-tidy] Use CloexecCheck as base class.

2017-08-16 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh updated this revision to Diff 111372. chh marked 3 inline comments as done. https://reviews.llvm.org/D36761 Files: clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h clang-tidy/android/CloexecCreatCheck.cpp clang-tidy/android/CloexecCreatCheck.h

[PATCH] D36761: [clang-tidy] Use CloexecCheck as base class.

2017-08-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM with a few nits. Comment at: clang-tidy/android/CloexecCheck.h:95 + /// Binding name of the FuncDecl of a function call. + static const char *FuncDeclBindingStr; +

[PATCH] D36761: [clang-tidy] Use CloexecCheck as base class.

2017-08-15 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh updated this revision to Diff 111243. chh edited the summary of this revision. https://reviews.llvm.org/D36761 Files: clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h clang-tidy/android/CloexecCreatCheck.cpp clang-tidy/android/CloexecCreatCheck.h

[PATCH] D36761: [clang-tidy] Use CloexecCheck as base class.

2017-08-15 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh created this revision. Simplify registerMatchers and check functions in CloexecCreatCheck, CloexecSocketCheck, and CloexecFopenCheck. https://reviews.llvm.org/D36761 Files: clang-tidy/android/CloexecCreatCheck.cpp clang-tidy/android/CloexecCreatCheck.h