[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-12-14 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Fixed in r320766. Sorry about that! Repository: rL LLVM https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-12-14 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In https://reviews.llvm.org/D36952#955937, @jklaehn wrote: > Thanks! However, compared to diff 126298 > (https://reviews.llvm.org/differential/diff/126298/), there seems to be > duplication in the committed change (maybe some artifacts due to > rebasing/merging?).

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-12-14 Thread Johann Klähn via Phabricator via cfe-commits
jklaehn added a comment. Thanks! However, compared to diff 126298 (https://reviews.llvm.org/differential/diff/126298/), there seems to be duplication in the committed change (maybe some artifacts due to rebasing/merging?). Should I submit a follow-up patch to fix this?

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-12-14 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320748: [libclang] Add support for checking abstractness of records (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D36952?vs=126298=127021#toc Repository:

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-12-14 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Sure, I'll do it today. https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-12-12 Thread Johann Klähn via Phabricator via cfe-commits
jklaehn added a comment. In https://reviews.llvm.org/D36952#951616, @arphaman wrote: > LGTM Thanks! Can you submit this for me? (I do not have commit access yet.) https://reviews.llvm.org/D36952 ___ cfe-commits mailing list

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-12-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-12-10 Thread Johann Klähn via Phabricator via cfe-commits
jklaehn updated this revision to Diff 126298. jklaehn added a comment. ping (rebased) https://reviews.llvm.org/D36952 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor.py include/clang-c/Index.h test/Index/load-classes.cpp

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-10-24 Thread Johann Klähn via Phabricator via cfe-commits
jklaehn added a comment. ping :) https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-08-21 Thread Johann Klähn via Phabricator via cfe-commits
jklaehn created this revision. jklaehn added a project: clang. This patch allows checking whether a C++ record declaration is abstract through libclang and clang.cindex (Python). https://reviews.llvm.org/D36952 Files: bindings/python/clang/cindex.py