This revision was automatically updated to reflect the committed changes.
Closed by commit rL315958: [libclang] Visit attributes for function and class
templates (authored by jbcoe).
Changed prior to commit:
https://reviews.llvm.org/D36955?vs=118330=119233#toc
Repository:
rL LLVM
jklaehn added a comment.
In https://reviews.llvm.org/D36955#893856, @jbcoe wrote:
> LGTM
>
> Would you like me to commit this for you?
Yes, I would appreciate it.
https://reviews.llvm.org/D36955
___
cfe-commits mailing list
jbcoe accepted this revision.
jbcoe added a comment.
This revision is now accepted and ready to land.
LGTM
Would you like me to commit this for you?
https://reviews.llvm.org/D36955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jklaehn updated this revision to Diff 118330.
jklaehn added a comment.
Added `c-index-test`-based test.
https://reviews.llvm.org/D36955
Files:
bindings/python/tests/cindex/test_cursor.py
test/Index/annotate-attribute.cpp
tools/libclang/CIndex.cpp
Index: tools/libclang/CIndex.cpp
jbcoe requested changes to this revision.
jbcoe added a comment.
This revision now requires changes to proceed.
Looks great. Please add tests to clang/tools/c-index-test/c-index-test.c too as
the Python tests are not run on build-bots (to the best of my knowledge).
jklaehn added a reviewer: jbcoe.
jklaehn added a comment.
ping :)
https://reviews.llvm.org/D36955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jklaehn created this revision.
jklaehn added a project: clang.
Previously, `VisitAttributes` was not called for function and class templates
and thus their attributes were not accessible using libclang.
https://reviews.llvm.org/D36955
Files:
bindings/python/tests/cindex/test_cursor.py
