This revision was automatically updated to reflect the committed changes.
Closed by commit rL312256: [test] Cleanup nullopt_t tests (authored by
CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D37024?vs=112224=113432#toc
Repository:
rL LLVM
https://reviews.llvm.org/D37024
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D37024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
CaseyCarter updated this revision to Diff 112224.
CaseyCarter added a comment.
Don't unnecessarily fully qualify `std::nullopt`.
https://reviews.llvm.org/D37024
Files:
test/std/utilities/optional/optional.nullopt/not_brace_initializable.fail.cpp
STL_MSFT added a comment.
Otherwise, looks cromulent to me.
Comment at: test/std/utilities/optional/optional.nullopt/nullopt_t.pass.cpp:38
-static_assert(test(nullopt) == 3, "");
+static_assert(std::is_same_v);
+static_assert(test());
You're
CaseyCarter created this revision.
- Update specification text from N4387
- Delete `not_brace_initializable.fail.cpp`: it's redundant with
`nullopt_t.fail.cpp`
- `is_empty` implies `is_class`
- `is_literal` is deprecated; directly verify that we can create a `nullopt_t`
in a `constexpr`
