ilya-biryukov added a comment.
In https://reviews.llvm.org/D37101#868207, @rwols wrote:
> Thanks! Thinking ahead now so we're on the same page, you will be
> implementing the client's initialize request, and I'll start work on
> textDocument/signatureHelp.
Sounds good.
rwols added a comment.
Thanks! Thinking ahead now so we're on the same page, you will be implementing
the client's initialize request, and I'll start work on
textDocument/signatureHelp.
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
ilya-biryukov closed this revision.
ilya-biryukov added a comment.
Marking as closed, had to commit by hand without `arc patch` as it couldn't
find base revision to apply the patch on.
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
ilya-biryukov added a comment.
Done. It's now in. Thanks for the contribution!
Had to make a few changes before committing.
- Fix compilation of tests.
- Update VSCode "engine" dependency in vscode toy client.
https://reviews.llvm.org/D37101
rwols added a comment.
No, I don't have access to the repo, sorry forgot to mention this.
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added a comment.
@rwols, do you have access to svn repo? If not, I can submit this change for
you.
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rwols updated this revision to Diff 114415.
rwols added a comment.
Update the description for the "-enable-snippets" option.
https://reviews.llvm.org/D37101
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
krasimir accepted this revision.
krasimir added a comment.
Great!
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks for the change! Looks good minus an outdated description of
`enable-snippets` flag.
Do you have commit access to llvm repository?
Comment at:
rwols updated this revision to Diff 114242.
rwols added a comment.
Change command-line option back to "-enable-snippets", disable snippets by
default. This is a temporary solution and we should instead inspect the
"initialize" request from the client to check wether the client supports
rwols marked an inline comment as done.
rwols added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:33
+ "present plaintext completions."),
+llvm::cl::init(false));
+
ilya-biryukov wrote:
> After
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:376
+
+CompletionItem Item{InsertTextFormat::PlainText};
+
rwols wrote:
> ilya-biryukov wrote:
> > Implementations of this function in `PlainTextCompletionItemsCollector` and
> >
ilya-biryukov added a comment.
Looks good, just one major drawback to address. We shouldn't break clients by
default (see comment in `ClangdMain.cpp`).
And a minor comment about flag naming.
Comment at: clangd/tool/ClangdMain.cpp:30
+static llvm::cl::opt
+
rwols marked 7 inline comments as done.
rwols added inline comments.
Comment at: clangd/ClangdUnit.cpp:376
+
+CompletionItem Item{InsertTextFormat::PlainText};
+
ilya-biryukov wrote:
> Implementations of this function in `PlainTextCompletionItemsCollector`
rwols updated this revision to Diff 113899.
rwols added a comment.
- Don't use const for non-reference parameters
- `lowerCamelCase` for functions, verb phrase
- Field definitions at the bottom of the class
- Make ProcessChunks virtual
- Add comment that fallthrough to the next case is intended
-
rwols updated this revision to Diff 113901.
rwols added a comment.
- Fix failing clangd tests
https://reviews.llvm.org/D37101
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
ilya-biryukov added a comment.
Looks good overall, just a bunch of comments before accepting the revision.
Mostly minor code style issues, sorry for spamming you with those.
Comment at: clangd/ClangdLSPServer.h:30
ClangdLSPServer(JSONOutput , unsigned AsyncThreadsCount,
+
17 matches
Mail list logo
