[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL313072: Handle object files named *.obj in merge_archives.py (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D37133?vs=114893=114906#toc Repository: rL LLVM

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

mstorsjo updated this revision to Diff 114893. mstorsjo added a comment. Using `*.o*` instead of checking `*.obj` separately. https://reviews.llvm.org/D37133 Files: utils/merge_archives.py Index: utils/merge_archives.py ===

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

mstorsjo added inline comments. Comment at: utils/merge_archives.py:121 files = glob.glob(os.path.join(temp_directory_root, '*.o')) if not files: EricWF wrote: > How about simply using `*.o*`? Sure, that would probably work as well.

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

EricWF added inline comments. Comment at: utils/merge_archives.py:121 files = glob.glob(os.path.join(temp_directory_root, '*.o')) if not files: How about simply using `*.o*`? https://reviews.llvm.org/D37133

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

EricWF added a comment. In https://reviews.llvm.org/D37133#860549, @compnerd wrote: > I think we should avoid this logic entirely and use CMake to do this. It's not that easy to do in CMake, and a CMake solution would be limited to only merging in-tree builds together. This script allows

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

mstorsjo added a comment. Ping @EricWF, who added this script https://reviews.llvm.org/D37133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

mstorsjo added a comment. In https://reviews.llvm.org/D37133#860563, @compnerd wrote: > `$` should give you the `.o` or `.obj` > files used to construct the library. I guess that would only work if they're built all as part of the same CMake invocation?

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

compnerd added a comment. `$` should give you the `.o` or `.obj` files used to construct the library. https://reviews.llvm.org/D37133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

mstorsjo added a comment. Do you have any pointers on how to do it with CMake? https://reviews.llvm.org/D37133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. I think we should avoid this logic entirely and use CMake to do this. https://reviews.llvm.org/D37133 ___ cfe-commits mailing list

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

mstorsjo added a comment. Ping https://reviews.llvm.org/D37133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

mstorsjo created this revision. https://reviews.llvm.org/D37133 Files: utils/merge_archives.py Index: utils/merge_archives.py === --- utils/merge_archives.py +++ utils/merge_archives.py @@ -120,6 +120,8 @@ files =