rjmccall added a comment.
Is that really the way we want to recommend formatting that, with the generics
clause separated from the class name but not separated from the category
clause? I'd expect the opposite: write the generics clause with no separation
after the class name but with
shafik added subscribers: Eugene.Zelenko, rjmccall, shafik.
shafik added a comment.
Herald added projects: All, clang, clang-format.
Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay.
@rjmccall @Eugene.Zelenko this looks like it might still be relevant.
CHANGES SINCE
danielmartin updated this revision to Diff 112855.
danielmartin added a comment.
Make comment fit in one line
https://reviews.llvm.org/D37192
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Format/UnwrappedLineParser.cpp:2099
+ // After a protocol list, we can have a category (Obj-C generic
+ // category).
nit:
danielmartin created this revision.
Herald added a subscriber: klimek.
Objective C supports lightweight generics in categories. This patch
adds support for that in clang-format.
https://reviews.llvm.org/D37192
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestObjC.cpp
