[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

2017-09-12 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman closed this revision. arphaman added a comment. Committed in r313025 Repository: rL LLVM https://reviews.llvm.org/D37210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

2017-09-01 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 113521. arphaman added a comment. Rebase on ToT Repository: rL LLVM https://reviews.llvm.org/D37210 Files: include/clang/Tooling/Refactoring/RefactoringResultConsumer.h unittests/Tooling/RefactoringActionRulesTest.cpp Index:

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

2017-08-30 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth resigned from this revision. JonasToth added a comment. This revision is now accepted and ready to land. sry. misconfigured herald :( Repository: rL LLVM https://reviews.llvm.org/D37210 ___ cfe-commits mailing list

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

2017-08-30 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 113224. arphaman marked an inline comment as done. arphaman added a comment. Herald added a reviewer: JonasToth. This revision now requires review to proceed. Rebase on top of https://reviews.llvm.org/D37291 Repository: rL LLVM

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

2017-08-30 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:29 +SourceChangeRefactoringRuleKind, +FindSymbolOccurrencesRefactoringRuleKind + }; hokein wrote: > I might miss some context here. As per your comment

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

2017-08-30 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:29 +SourceChangeRefactoringRuleKind, +FindSymbolOccurrencesRefactoringRuleKind + }; I might miss some context here. As per your comment in

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

2017-08-29 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lgtm Repository: rL LLVM https://reviews.llvm.org/D37210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

2017-08-28 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. This patch adds a second kind of refactoring action rule that produces symbol occurrences. It will be used by the updated `clang-refactor` patch at https://reviews.llvm.org/D36574. Repository: rL LLVM https://reviews.llvm.org/D37210 Files: