This revision was automatically updated to reflect the committed changes.
Closed by commit rC339284: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL
(authored by pirama, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D37302?vs=159330=159778#toc
Repository:
rC Clang
ldionne added a comment.
In https://reviews.llvm.org/D37302#1189576, @pirama wrote:
> Sorry this fell of my radar. I've rebased the patch.
>
> Since this has been inactive for a while, lets wait for a couple of days to
> see if there are any other comments. If there are no objections, I'll
pirama added a comment.
Sorry this fell of my radar. I've rebased the patch.
Since this has been inactive for a while, lets wait for a couple of days to see
if there are any other comments. If there are no objections, I'll submit this
on Wednesday.
Repository:
rC Clang
pirama updated this revision to Diff 159330.
pirama added a comment.
Rebase
Repository:
rC Clang
https://reviews.llvm.org/D37302
Files:
lib/Headers/float.h
test/Headers/float.c
Index: test/Headers/float.c
===
---
ldionne accepted this revision.
ldionne added a comment.
What are we waiting for to move forward with this change?
Repository:
rC Clang
https://reviews.llvm.org/D37302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pirama updated this revision to Diff 139670.
pirama added a comment.
Remove unexpected change from another patch.
Repository:
rC Clang
https://reviews.llvm.org/D37302
Files:
lib/Headers/float.h
test/Headers/float.c
Index: test/Headers/float.c
pirama updated this revision to Diff 139667.
pirama added a comment.
- [CodeGen] Mark fma as const for Android
Repository:
rC Clang
https://reviews.llvm.org/D37302
Files:
lib/Headers/float.h
lib/Sema/SemaDecl.cpp
test/CodeGen/math-builtins.c
test/Headers/float.c
Index:
pirama updated this revision to Diff 139666.
pirama added a comment.
- [CodeGen] Mark fma as const for Android
Repository:
rC Clang
https://reviews.llvm.org/D37302
Files:
lib/Headers/float.h
lib/Sema/SemaDecl.cpp
test/CodeGen/math-builtins.c
test/Headers/float.c
Index:
pirama updated this revision to Diff 124314.
pirama added a comment.
Revert to previous patch after accidental update
https://reviews.llvm.org/D37302
Files:
lib/Driver/ToolChains/Gnu.cpp
lib/Headers/float.h
test/Driver/as-mcpu.c
test/Headers/float.c
Index: test/Headers/float.c
pirama updated this revision to Diff 124315.
pirama added a comment.
Actually revert
https://reviews.llvm.org/D37302
Files:
lib/Headers/float.h
test/Headers/float.c
Index: test/Headers/float.c
===
--- test/Headers/float.c
pirama updated this revision to Diff 124313.
pirama added a comment.
- Switch kryo to use -mcpu=cortex-a57 when invoking the assembler
https://reviews.llvm.org/D37302
Files:
lib/Driver/ToolChains/Gnu.cpp
lib/Headers/float.h
test/Driver/as-mcpu.c
test/Headers/float.c
Index:
It's supposed to tell you whether the target arch supports it. So it's
definitely something the compiler knows better than the C library, which is
why I didn't just work around this myself
Clang may not be correct right now, but if that's true, (a) it's already
lying to us through the other
pirama added a comment.
In https://reviews.llvm.org/D37302#871794, @joerg wrote:
> So what about targets that don't support subnormals? I'm moderately sure ARM
> falls into this category given the right phase of the moon.
Clang defines `__FLT_HAS_DENORM__` and friends unconditionally, so I
joerg added a comment.
So what about targets that don't support subnormals? I'm moderately sure ARM
falls into this category given the right phase of the moon.
https://reviews.llvm.org/D37302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pirama added a comment.
@bruno Any suggestion on how to update test/Headers/float-darwin,c* so make it
check the include_next? I am unable to find the darwin-specific float.h inside
an XCode installation directory.
- Oops, my earlier comment had the wrong test name
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pirama added a comment.
Ping
https://reviews.llvm.org/D37302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pirama added a comment.
Ping...
https://reviews.llvm.org/D37302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
18 matches
Mail list logo
