xazax.hun added a comment.
https://reviews.llvm.org/D41538 is superior and committed.
https://reviews.llvm.org/D37437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added a comment.
Herald added subscribers: a.sidorin, rnkovacs.
In case you do not like this solution, I uploaded an alternative approach:
https://reviews.llvm.org/D41538
https://reviews.llvm.org/D37437
___
cfe-commits mailing list
xazax.hun added a comment.
@dcoughlin do you have some input on this?
https://reviews.llvm.org/D37437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added a comment.
In https://reviews.llvm.org/D37437#909537, @zaks.anna wrote:
> Just to be clear, since this leads to regression to the checker API, I am
> asking to look into other ways of solving this problem. For example, is there
> a way to ensure that the checker names are set
zaks.anna added a comment.
Just to be clear, since this leads to regression to the checker API, I am
asking to look into other ways of solving this problem. For example, is there a
way to ensure that the checker names are set at construction?
https://reviews.llvm.org/D37437
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:308
if (StOutBound && !StInBound) {
+if (!Filter.CheckCStringOutOfBounds)
+ return state;
zaks.anna wrote:
> This seems to be related to the change in the
xazax.hun updated this revision to Diff 119141.
xazax.hun marked 2 inline comments as done.
xazax.hun added a comment.
Herald added a subscriber: szepet.
- Address review comments.
https://reviews.llvm.org/D37437
Files:
include/clang/StaticAnalyzer/Core/BugReporter/BugType.h
zaks.anna added a comment.
Looks like the need to have the checker name in BugType along with the checker
names not being initialized early enough, leads to worse checker-writer
experience. Is there a way to ensure that the checker names are set at
construction?
Comment at:
xazax.hun added a comment.
Ping.
https://reviews.llvm.org/D37437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added a comment.
In https://reviews.llvm.org/D37437#860311, @NoQ wrote:
> Cool. Thanks!
>
> > In the future probably it would be better to alter the signature of the
> > checkers' constructor to set the name in the constructor so it is possible
> > to create the BugType eagerly.
>
>
xazax.hun updated this revision to Diff 113837.
xazax.hun retitled this revision from "[analyzer] Fix SimpleStreamChecker's
output plist not containing the checker name" to "[analyzer] Fix some checker's
output plist not containing the checker name".
xazax.hun edited the summary of this
11 matches
Mail list logo
