This revision was automatically updated to reflect the committed changes.
Closed by commit rC336930: [C++17] Disallow lambdas in template parameters
(PR33696). (authored by Rakete, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D37442?vs=155240&id=155243#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336930: [C++17] Disallow lambdas in template parameters
(PR33696). (authored by Rakete, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D37442
Rakete updated this revision to Diff 155240.
Rakete added a comment.
Format lines longer than 80 characters correctly.
Repository:
rC Clang
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/
rsmith accepted this revision.
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:4000-4004
+ ExpressionEvaluationContextRecord::ExpressionKind Type =
ExpressionEvaluationContextRecord::EK_Other);
enum ReuseLambdaContextDecl_t { ReuseLambdaContextDecl };
Rakete updated this revision to Diff 154880.
Rakete added a comment.
Rebased + friendly ping
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseStmt.cpp
Rakete updated this revision to Diff 153149.
Rakete added a comment.
Added expression evaluation context to TreeTransform :)
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX
rsmith accepted this revision.
rsmith added a comment.
Please also change the `EnterExpressionEvaluationContext` in
`TreeTransform::TransformTemplateArgument` to specify `EK_TemplateArgument`
(though that doesn't actually matter for the lambda diagnostics because we'll
find all the problems in
Rakete updated this revision to Diff 152374.
Rakete added a comment.
Rebased + friendly ping :)
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseStmt.cp
Rakete updated this revision to Diff 148555.
Rakete added a comment.
Rebase and friendly ping :)
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseStmt.c
Rakete updated this revision to Diff 138337.
Rakete added a comment.
Rebase and ping :)
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseStmt.cpp
lib/
Rakete updated this revision to Diff 130014.
Rakete added a comment.
I put the enum in `ExpressionEvaluationContextRecord` now, and fixed the `Type`
-> `Kind` issue.
If it's still ok, could you please commit it @rsmith? Thanks :)
https://reviews.llvm.org/D37442
Files:
include/clang/
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, looks good other than `ExpressionType`. This is fine to commit with
either of the names I suggested; let me know if you have a better alternative :)
Comment at: incl
Rakete updated this revision to Diff 128667.
Rakete added a comment.
Rebased + friendly 2018 ping
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseStmt.
Rakete updated this revision to Diff 117568.
Rakete added a comment.
- rebased
Does anyone have a better name than `ExpressionType`? I don't really like it.
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/Parse
Rakete updated this revision to Diff 114204.
Rakete added a comment.
Good idea! Updated diff :)
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseStmt.cp
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:979-980
Decl *ManglingContextDecl,
- bool IsDecltype)
+ bool IsDecltype,
+
Rakete created this revision.
This revision disallows lambdas in template parameters, as reported in PR33696.
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseTemplate.cpp
lib/Sema/Sema.cpp
lib/Sema/SemaExpr
17 matches
Mail list logo
