[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

aaron.ballman added a comment. In D37624#3838587 , @paquette wrote: > +1, someone just asked me if this feature exists and then found this patch. > If this could be revived, I think it would help a lot of folks out. :) I took a quick pass over it and the

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

paquette added a comment. +1, someone just asked me if this feature exists and then found this patch. If this could be revived, I think it would help a lot of folks out. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37624/new/ https://reviews.llvm.org/D37624 ___

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

hiraditya added a comment. Herald added a project: All. Is there a plan to revive this? this is quite necessary for one of my use cases. can we at least have '-fno-instrument-functions'? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37624/new/ https://reviews.llvm.org/D37624 __

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

oliverbrowne added a comment. Hi Folks, don't know if this review is still active but I can provide some context on the GCC behavior with respect to namespaces, template params and function arguments, they were bugs, fixed in 2019. Associated bug reports for namespace/class, and template parame

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

hfinkel added a comment. In https://reviews.llvm.org/D37624#1211748, @apazos wrote: > Hello folks, is there a plan to merge this feature still? There's still a desire for the underlying functionality. We still need, as I recall, to figure out what's supposed to happen for C++ functions. http

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

apazos added a comment. Herald added a subscriber: erik.pilkington. Hello folks, is there a plan to merge this feature still? https://reviews.llvm.org/D37624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa updated this revision to Diff 120252. choikwa added a comment. rebase to trunk https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenF

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

hfinkel added a comment. In https://reviews.llvm.org/D37624#885438, @choikwa wrote: > > Can you get more information on what GCC actually implemented and why? It's > > not clear to me that ignoring the namespaces is the most-useful way to do > > this. I don't want to emulate GCC bugs, but maybe

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa added a comment. > Can you get more information on what GCC actually implemented and why? It's > not clear to me that ignoring the namespaces is the most-useful way to do > this. I don't want to emulate GCC bugs, but maybe there's a good reason why > their implementation works this way.

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

hfinkel added a comment. In https://reviews.llvm.org/D37624#885311, @choikwa wrote: > In https://reviews.llvm.org/D37624#885308, @hfinkel wrote: > > > In https://reviews.llvm.org/D37624#885295, @choikwa wrote: > > > > > In https://reviews.llvm.org/D37624#885290, @hfinkel wrote: > > > > > > > In h

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa added a comment. In https://reviews.llvm.org/D37624#885308, @hfinkel wrote: > In https://reviews.llvm.org/D37624#885295, @choikwa wrote: > > > In https://reviews.llvm.org/D37624#885290, @hfinkel wrote: > > > > > In https://reviews.llvm.org/D37624#885288, @choikwa wrote: > > > > > > > - ad

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

hfinkel added a comment. In https://reviews.llvm.org/D37624#885295, @choikwa wrote: > In https://reviews.llvm.org/D37624#885290, @hfinkel wrote: > > > In https://reviews.llvm.org/D37624#885288, @choikwa wrote: > > > > > - add comment to CPP test to explain usage > > > > > > Thanks. Please also ad

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa added a comment. In https://reviews.llvm.org/D37624#885290, @hfinkel wrote: > In https://reviews.llvm.org/D37624#885288, @choikwa wrote: > > > - add comment to CPP test to explain usage > > > Thanks. Please also add some tests showing matching overloaded functions, > functions with templ

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

majnemer added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:455 +for (const auto &FileMatch : PathSearch) { + if(FunctionDeclPath.find(FileMatch) != std::string::npos) { +return false; Space after if. Comment at

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa updated this revision to Diff 117269. choikwa added a comment. - add more CPP tests: func overload, template special https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/Code

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

hfinkel added a comment. In https://reviews.llvm.org/D37624#885288, @choikwa wrote: > - add comment to CPP test to explain usage Thanks. Please also add some tests showing matching overloaded functions, functions with template parameters, etc. Do we need to strip whitespace before trying to m

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa updated this revision to Diff 117268. choikwa added a comment. - add comment to CPP test to explain usage https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CodeGenFunction

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

hfinkel added inline comments. Comment at: test/CodeGenCXX/instrument-functions.cpp:8 +// RUN: %clang -S -emit-llvm -o - %s -finstrument-functions -finstrument-functions-exclude-function-list=test3 | FileCheck %s --check-prefix=NOFUNC +// RUN: %clang -S -emit-llvm -o - %s -fins

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa updated this revision to Diff 117267. choikwa added a comment. - - Address formating feedback, remove redundant inline https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/Co

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

majnemer added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:463 + + // Skip demangling if decl is extern "C" + if (ActualFuncDecl && !ActualFuncDecl->isExternC()) { Is this comment still correct? Comment at: lib/CodeGen/CodeGe

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa updated this revision to Diff 117264. choikwa added a comment. Addressing Hal's feedback https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CodeGenFunction.cpp lib/CodeGe

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

hfinkel added a comment. Please also add a C++ test to check the mangling-related features. Comment at: lib/CodeGen/CodeGenFunction.cpp:419 +// Assume that __cxa_demangle is provided by libcxxabi (except for Windows). +extern "C" char *__cxa_demangle(const char *mangled_name, c

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa updated this revision to Diff 114388. choikwa added a comment. renamed and moved Cache to SourceLocToFileNameMap in CodeGenModule https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa added a comment. Forgot to hang Cache to CodeGenModule, will do that shortly https://reviews.llvm.org/D37624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa updated this revision to Diff 114380. choikwa added a comment. addressed code review. made doc consistent with functionality. https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/Cod

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

aaron.ballman added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:425 /// instrumented with __cyg_profile_func_* calls -bool CodeGenFunction::ShouldInstrumentFunction() { +bool CodeGenFunction::ShouldInstrumentFunction(llvm::Function *Fn) { + typedef std::vector:

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

choikwa created this revision. Builds on previous Differential https://reviews.llvm.org/D2219 Changes include: - Using unordered_map with SourceLocation.ID (raw encoding) as key - Demangle only if !isExternC. Used dyn_cast((Decl*)CurFuncDecl) for this - Modified an existing C testcase to test f