This revision was automatically updated to reflect the committed changes.
Closed by commit rL313624: Lowering Mask Set1 intrinsics to LLVM IR (authored
by jina.nahias).
Changed prior to commit:
https://reviews.llvm.org/D37668?vs=115622&id=115823#toc
Repository:
rL LLVM
https://reviews.llvm.
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
jina.nahias added inline comments.
Comment at: lib/Headers/avx512fintrin.h:9742
#ifdef __x86_64__
static __inline__ __m512i __DEFAULT_FN_ATTRS
craig.topper wrote:
> Please remove the #ifdef __x86_64__ from this. It should work in 32-bits as
> well.
the curre
jina.nahias updated this revision to Diff 115622.
jina.nahias added a comment.
rebase on @craig.topper commit.
https://reviews.llvm.org/D37668
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
li
craig.topper added a comment.
I'm going to go ahead and remove __builtin_ia32_pbroadcastq512_mem_mask from
clang and change _mm512_maskz_set1_epi64 to be disabled in 32-bit mode. I want
to nominate this for 5.0.1 because using it in 32-bit mode causes the compile
to throw a cannot select error.
jina.nahias added inline comments.
Comment at: include/clang/Basic/BuiltinsX86.def:981
-TARGET_BUILTIN(__builtin_ia32_pbroadcastd512_gpr_mask, "V16iiV16iUs", "",
"avx512f")
TARGET_BUILTIN(__builtin_ia32_pbroadcastq512_mem_mask, "V8LLiLLiV8LLiUc", "",
"avx512f")
TARGET_BUILTIN
jina.nahias updated this revision to Diff 114978.
https://reviews.llvm.org/D37668
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
lib/Headers/avx512vlbwintrin.h
lib/Headers/avx512vlintrin.h
te
RKSimon added a comment.
some very minor whitespace/indentation issues
please can you confirm @craig.topper's query about
__builtin_ia32_pbroadcastq512_mem_mask
Comment at: lib/Headers/avx512vlintrin.h:5727
+static __inline__ __m128i __DEFAULT_FN_ATTRS
+ _mm_mask_set1_epi32(
jina.nahias updated this revision to Diff 114836.
https://reviews.llvm.org/D37668
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
lib/Headers/avx512vlbwintrin.h
lib/Headers/avx512vlintrin.h
te
craig.topper added inline comments.
Comment at: include/clang/Basic/BuiltinsX86.def:981
-TARGET_BUILTIN(__builtin_ia32_pbroadcastd512_gpr_mask, "V16iiV16iUs", "",
"avx512f")
TARGET_BUILTIN(__builtin_ia32_pbroadcastq512_mem_mask, "V8LLiLLiV8LLiUc", "",
"avx512f")
TARGET_BUILTI
jina.nahias updated this revision to Diff 114765.
https://reviews.llvm.org/D37668
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
lib/Headers/avx512vlbwintrin.h
lib/Headers/avx512vlintrin.h
te
craig.topper added a comment.
I think when you uploaded the changes to remove it from BuiltinsX86.def you
lost your earlier changes to the header files
https://reviews.llvm.org/D37668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
jina.nahias updated this revision to Diff 114594.
jina.nahias added a comment.
delete from include/clang/Basic/BuiltinsX86.def and
include/clang/Basic/BuiltinsX86_64.def
https://reviews.llvm.org/D37668
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
Inde
RKSimon added a comment.
As with https://reviews.llvm.org/D37562, strip the builtins from
include/clang/Basic/BuiltinsX86.def
https://reviews.llvm.org/D37668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
jina.nahias created this revision.
this is clang part , the llvm part is
https://reviews.llvm.org/differential/diff/114515/
https://reviews.llvm.org/D37668
Files:
lib/Headers/avx512bwintrin.h
lib/Headers/avx512fintrin.h
lib/Headers/avx512vlbwintrin.h
lib/Headers/avx512vlintrin.h
test
15 matches
Mail list logo