nik added a comment.
In https://reviews.llvm.org/D37700#867646, @ilya-biryukov wrote:
> @nik, could you file a separate bug so that we won't forget about it?
Done, it's https://bugs.llvm.org/show_bug.cgi?id=34570 .
Repository:
rL LLVM
https://reviews.llvm.org/D37700
ilya-biryukov added a comment.
In https://reviews.llvm.org/D37700#867625, @erikjv wrote:
> I'd put/fix Nik's issue in a separate patch.
Totally agree. It seems like a separate issue, though maybe related.
@nik, could you file a separate bug so that we won't forget about it?
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313014: Fix recording preamble's conditional stack in
skipped PP branches. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D37700
Files:
cfe/trunk/lib/Lex/PPDirectives.cpp
erikjv added a comment.
I'd put/fix Nik's issue in a separate patch.
https://reviews.llvm.org/D37700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Fixes the reported issue, thanks!
I still run into another case that is not yet properly covered. The reported
issue was extracted from the following case. If you prefer, I'll create a
separate report for the remaining issues.
The follow code outlines the problems in the
ilya-biryukov updated this revision to Diff 114634.
ilya-biryukov added a comment.
Fixed description of the change.
https://reviews.llvm.org/D37700
Files:
lib/Lex/PPDirectives.cpp
test/Index/preamble-conditionals-inverted-with-error.cpp
test/Index/preamble-conditionals-inverted.cpp
ilya-biryukov created this revision.
This fixes PR34547.
`Lexer::LexEndOfFile` handles recording of ConditionalStack for
preamble and reporting errors about unmatched conditionalal PP
directives.
However, SkipExcludedConditionalBlock contianed duplicated logic for
reporting errors and clearing
