[PATCH] D37980: [clang-format] Better parsing of lambda captures with initializer expressions.

2017-09-19 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius abandoned this revision. curdeius added a comment. Ok. Nice patch. You can close https://bugs.llvm.org/show_bug.cgi?id=19986 now. https://reviews.llvm.org/D37980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D37980: [clang-format] Better parsing of lambda captures with initializer expressions.

2017-09-19 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added a comment. Thanks for the patch and the discussion around this. I fixed this in r313622 in what I think is a more principled approach that also works for nested lambdas (and gets rid of a lot of now-obsolete code). The big problem with this code was that it evolved a bit to the poin

[PATCH] D37980: [clang-format] Better parsing of lambda captures with initializer expressions.

2017-09-19 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius updated this revision to Diff 115814. curdeius added a comment. Minor: use `FormatToken::isNot` instead of `!FormatToken::is`. https://reviews.llvm.org/D37980 Files: lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTest.cpp Index: unitte

[PATCH] D37980: [clang-format] Better parsing of lambda captures with initializer expressions.

2017-09-18 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius created this revision. This fixes bug #19986 (https://bugs.llvm.org/show_bug.cgi?id=19986). The code was incorrectly formatted to (mind additional spaces inside brackets) when lambda capture contained an initializer expression. This patch does not handle all possible initializers, but th