[PATCH] D38202: Add Documentation to attribute-nothrow. Additionally, limit to functions.

2017-09-28 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314456: Add Documentation to attribute-nothrow. Additionally, limit to functions. (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38202?vs=116705=117044#toc Repository:

[PATCH] D38202: Add Documentation to attribute-nothrow. Additionally, limit to functions.

2017-09-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D38202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38202: Add Documentation to attribute-nothrow. Additionally, limit to functions.

2017-09-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 116705. erichkeane added a comment. Added declspec, fixed does cannot. https://reviews.llvm.org/D38202 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td test/Misc/pragma-attribute-supported-attributes-list.test Index:

[PATCH] D38202: Add Documentation to attribute-nothrow. Additionally, limit to functions.

2017-09-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2692 + let Content = [{ +Clang supports the GNU style ``__attribute__((nothrow))`` attribute as an +equivilent of `noexcept` on function declarations. This

[PATCH] D38202: Add Documentation to attribute-nothrow. Additionally, limit to functions.

2017-09-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2692 + let Content = [{ +Clang supports the GNU style ``__attribute__((nothrow))`` attribute as an +equivilent of `noexcept` on function declarations. This attribute informs the

[PATCH] D38202: Add Documentation to attribute-nothrow. Additionally, limit to functions.

2017-09-25 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. Herald added a subscriber: javed.absar. Attribute nothrow is only allowed on functions, so I added that. Additionally, it lacks any documentation, so I added some. Please wordsmith! https://reviews.llvm.org/D38202 Files: include/clang/Basic/Attr.td