[PATCH] D38214: [analyzer] Fix crash on modeling of pointer arithmetic

2017-09-25 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314141: [analyzer] Fix crash on modeling of pointer arithmetic (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D38214?vs=116455=116590#toc Repository: rL LLVM

[PATCH] D38214: [analyzer] Fix crash on modeling of pointer arithmetic

2017-09-25 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. Thanks for the fix! Repository: rL LLVM https://reviews.llvm.org/D38214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38214: [analyzer] Fix crash on modeling of pointer arithmetic

2017-09-25 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Looks good! I guess the accurate thing to do would be to return LocAsInteger of type `intptr_t` of an ElementRegion with index `-1` from SymbolicRegion around `p`. But i'm totally fine with another `UnknownVal` placeholder until this becomes an actual problem.

[PATCH] D38214: [analyzer] Fix crash on modeling of pointer arithmetic

2017-09-25 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap created this revision. Herald added a subscriber: xazax.hun. This patch attempts to fix analyzer's crash on the newly added test case (see also https://bugs.llvm.org/show_bug.cgi?id=34374). Pointer subtraction appears to be modeled incorrectly in the following example: char* p;