[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

erikjv closed this revision. erikjv added a comment. Submitted as r317308. https://reviews.llvm.org/D38578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

cameron314 added a comment. @nik, pretty sure this fix I submitted ages ago fixes that. Been using it in production a couple years. Would be nice if someone reviewed it so we could finally upstream it. https://reviews.llvm.org/D38578 ___

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

nik added a comment. This fixes the reported bug for me :) There is another related issue that is not addressed by this change. I've reported it as [preamble] Skipped ranges vanish after reparse (#ifdef with #include) https://bugs.llvm.org/show_bug.cgi?id=34971 https://reviews.llvm.org/D385

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

erikjv updated this revision to Diff 117986. https://reviews.llvm.org/D38578 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPDirectives.cpp lib/Lex/Preprocessor.cpp lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp test/Index/preamble-conditionals-inverted.cpp test/I

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Also, one more important thing. I'll unaccept revision for now, before getting feedback on this one. Comment at: include/clang/Lex/Preprocessor.h:333

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Only a few code style-related comments. Comment at: include/clang/Lex/Preprocessor.h:102 +bool ReachedEOFWhileSkipping; +SourceLocation HashToken;

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

erikjv created this revision. When a preamble ends in a conditional preprocessor block that is being skipped, the preprocessor needs to continue skipping that block when the preamble is used. This fixes PR34570. https://reviews.llvm.org/D38578 Files: include/clang/Lex/Preprocessor.h lib/Le