[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

2017-10-09 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In https://reviews.llvm.org/D38646#892246, @STL_MSFT wrote: > FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, > the first toolset update. 1912 will be the value for VS 2017 15.5, the second > toolset update. Yep. The initial draft of this patc

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

2017-10-09 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, the first toolset update. 1912 will be the value for VS 2017 15.5, the second toolset update. Repository: rL LLVM https://reviews.llvm.org/D38646 ___

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

2017-10-06 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315107: [MS] Raise the default value of _MSC_VER to 1911, which is VS 2017 (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D38646?vs=118079&id=118080#toc Repository: rL LLVM htt

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

2017-10-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 118079. rnk added a comment. - go to 1911, 1910 was the preview - add release notes https://reviews.llvm.org/D38646 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolChains/MSVC.cpp Index: clang/lib/Driver/ToolChains/MSVC.cpp ===

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

2017-10-06 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Should probably get a release note too. https://reviews.llvm.org/D38646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017

2017-10-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. This raises our default past 1900, which controls whether char16_t is a builtin type or not. Implements PR34243 https://reviews.llvm.org/D38646 Files: clang/lib/Driver/ToolChains/MSVC.cpp Index: clang/lib/Driver/ToolChains/MSVC.cpp ===