This revision was automatically updated to reflect the committed changes.
Closed by commit rL315624: [CUDA] Added __hmma_m16n16k16_* builtins to support
mma instructions on sm_70 (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D38742?vs=118636=118848#toc
Repository:
rL
jlebar added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9733
+ return nullptr;
+bool isColMajor = isColMajorArg.getZExtValue();
+unsigned IID;
tra wrote:
> jlebar wrote:
> > Urg, this isn't a bool? Do we want it to be?
> There are
tra added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9726
+ case NVPTX::BI__hmma_m16n16k16_ld_c_f16:
+case NVPTX::BI__hmma_m16n16k16_ld_c_f32:{
+Address Dst = EmitPointerWithAlignment(E->getArg(0));
jlebar wrote:
> weird indentation?
tra updated this revision to Diff 118636.
tra marked 6 inline comments as done.
tra added a comment.
Addressed Justin's comments.
https://reviews.llvm.org/D38742
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/builtins-nvptx-sm_70.cu
jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9726
+ case NVPTX::BI__hmma_m16n16k16_ld_c_f16:
+case NVPTX::BI__hmma_m16n16k16_ld_c_f32:{
+Address Dst =
tra created this revision.
Herald added subscribers: sanjoy, jholewinski.
https://reviews.llvm.org/D38742
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/builtins-nvptx-sm_70.cu
Index: clang/test/CodeGen/builtins-nvptx-sm_70.cu
