rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:337
+Mask = (Mask & ~ImplicitAddrSpaceMask) |
+ (((uint32_t)Value) << ImplicitAddrSpaceShift);
+ }
This is probably cleaner as:
Mask = (Value ? (Mask | ImplicitAddrSpaceMask)
yaxunl marked an inline comment as done.
yaxunl added a comment.
In https://reviews.llvm.org/D38857#896994, @Anastasia wrote:
> LGTM! Thanks!
>
> Can we close https://bugs.llvm.org/show_bug.cgi?id=33418 after this commit?
Will do.
Comment at:
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
Can we close https://bugs.llvm.org/show_bug.cgi?id=33418 after this commit?
Comment at: test/SemaOpenCL/null_literal.cl:38
-#ifdef CL20
-// Accept
yaxunl created this revision.
There are two issues:
1. only (void*)0 should be treated as nullptr
2. only explicit addr space should be printed
This patch introduces a flag in Qualifier to indicating a non-default address
space qualifier is deduced by context. Only
non-implicit address space
