[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

2018-03-27 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:100 + // This traverses the AST to catch certain bugs like poorly or not + // implemented subtrees. r.stahl wrote: > a.sidorin wrote: > > I just saw this change and I

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

2018-03-27 Thread Rafael Stahl via Phabricator via cfe-commits
r.stahl added inline comments. Herald added a subscriber: martong. Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:100 + // This traverses the AST to catch certain bugs like poorly or not + // implemented subtrees. a.sidorin wrote: > I just saw this

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

2018-01-30 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added inline comments. Herald added subscribers: llvm-commits, rnkovacs. Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:100 + // This traverses the AST to catch certain bugs like poorly or not + // implemented subtrees. I just saw this

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

2017-10-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316069: [ASTImporter] Import SubStmt of CaseStmt (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D38943?vs=119162=119444#toc Repository: rL LLVM

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

2017-10-16 Thread Rafael Stahl via Phabricator via cfe-commits
r.stahl added a comment. If all is good, I will need someone to commit this for me please. Comment at: unittests/AST/ASTImporterTest.cpp:100 + // This might catch other cases. + Imported->dump(ToNothing); xazax.hun wrote: > r.stahl wrote: > > xazax.hun

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

2017-10-16 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:100 + // This might catch other cases. + Imported->dump(ToNothing); r.stahl wrote: > xazax.hun wrote: > > I would elaborate a bit more on the purpose of the code below. > I will

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

2017-10-16 Thread Rafael Stahl via Phabricator via cfe-commits
r.stahl added a comment. Thanks for the fast response. See inline comment. Comment at: unittests/AST/ASTImporterTest.cpp:100 + // This might catch other cases. + Imported->dump(ToNothing); xazax.hun wrote: > I would elaborate a bit more on the purpose of

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

2017-10-16 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: unittests/AST/ASTImporterTest.cpp:100 + // This might catch other cases. + Imported->dump(ToNothing); I would

[PATCH] D38943: [ASTImporter] import SubStmt of CaseStmt

2017-10-16 Thread Rafael Stahl via Phabricator via cfe-commits
r.stahl created this revision. This fixes importing of CaseStmts, because the importer was not importing its SubStmt. A test was added and the test procedure was adjusted to also dump the imported Decl, because otherwise the bug would not be detected. https://reviews.llvm.org/D38943 Files: