[PATCH] D38969: Sort Attributes by "HeaderName"

This revision was automatically updated to reflect the committed changes. Closed by commit rL315931: Sort Attributes by "HeaderName" (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38969?vs=119195=119200#toc Repository: rL LLVM https://reviews.llvm.org/D38969

[PATCH] D38969: Sort Attributes by "HeaderName"

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D38969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38969: Sort Attributes by "HeaderName"

erichkeane updated this revision to Diff 119195. erichkeane added a comment. Change the constructor in DocumentationData to take by value. https://reviews.llvm.org/D38969 Files: utils/TableGen/ClangAttrEmitter.cpp Index: utils/TableGen/ClangAttrEmitter.cpp

[PATCH] D38969: Sort Attributes by "HeaderName"

erichkeane added inline comments. Comment at: utils/TableGen/ClangAttrEmitter.cpp:3670 + DocumentationData(const Record , const Record , +const std::pair &) + : Documentation(), Attribute(), Craig brought up that

[PATCH] D38969: Sort Attributes by "HeaderName"

erichkeane added a comment. Additionally, I'm going to edit the 'interrupt' docs in a separate commit to give each a separate header name based on the architecture. Currently they are all named 'interrupt', so I want to rename them all interrupt (x86), etc. Look for a future review!

[PATCH] D38969: Sort Attributes by "HeaderName"

erichkeane created this revision. Attributes in the docs were previously sorted (apparently) by the attribute name, so AnyX86Interrupt ended up being the first one, rather than in a meaningful place. This resulted in the 4 'interrupt' titled sections being all in different places. This replaces