faisalv abandoned this revision.
faisalv added a comment.
Just added an additional bit-field to FunctionDecl in
https://reviews.llvm.org/rL317984
Comment at: include/clang/AST/InlineDeclMembers.h:35
+
+#endif //LLVM_CLANG_AST_INLINEDECLMEMBERS_H
+
faisalv updated this revision to Diff 120346.
faisalv marked 4 inline comments as done.
faisalv added a comment.
Incorporated Aaron's feedback (although not sure if I caugh tall the white
space issues).
Additionally, I was thinking of reordering the bits - and using UseSEHTry (this
bit really
aaron.ballman added a comment.
I'll let Richard comment on whether this pattern is reasonable or not, but I
have some very minor nits in the meantime.
Comment at: include/clang/AST/Decl.h:1683
// Since a Deduction Guide [C++17] will never have a body, we can share the
-
faisalv added a comment.
In https://reviews.llvm.org/D39166#903131, @lichray wrote:
> Isn't it already an UB if someone set `WillHaveBody` and but later
> `IsCopyDeductionCandidate` being read, vice versa?
Yes that would be UB - but I'm not sure I see how that would happen w the
current
lichray added a comment.
Isn't it already an UB if someone set `WillHaveBody` and but later
`IsCopyDeductionCandidate` being read, vice versa?
Repository:
rL LLVM
https://reviews.llvm.org/D39166
___
cfe-commits mailing list
faisalv created this revision.
faisalv added a project: clang.
Herald added a subscriber: eraman.
I'd like to harden my patch here: https://reviews.llvm.org/rL316292 by adding
some assertions.
But since the assertions in Decl,.h (FunctionDecl) require knowledge from
DeclCXX.h
