[PATCH] D39290: [rename] Use SymbolOccurrence in RenameLocFinder.

2017-10-27 Thread Haojian Wu via Phabricator via cfe-commits
hokein abandoned this revision. hokein added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:74 +// The declaration in which the nested name is contained (can be nullptr). +const Decl *Context; +// The nested name being

[PATCH] D39290: [rename] Use SymbolOccurrence in RenameLocFinder.

2017-10-25 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Could you elaborate on the intention of this change? Is the intention of having more information in `SymbolOccurrence` to benefit users of the rename library or to simplify the internal implementation? Comment at:

[PATCH] D39290: [rename] Use SymbolOccurrence in RenameLocFinder.

2017-10-25 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. Herald added a subscriber: klimek. This is first step to integrate qualified rename into clang-refactor. Also a few changes to SymbolOccurrence: - add more information to SymbolOccurrence - remove the way of using SourceLocation as the array size