This revision was automatically updated to reflect the committed changes.
Closed by commit rL317293: [analyzer] do not crash on libcxx03 call_once
implementation (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39518?vs=121418=121423#toc
Repository:
rL LLVM
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks great. Thank you!
https://reviews.llvm.org/D39518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
george.karpenkov updated this revision to Diff 121418.
https://reviews.llvm.org/D39518
Files:
lib/Analysis/BodyFarm.cpp
test/Analysis/call_once.cpp
Index: test/Analysis/call_once.cpp
===
--- test/Analysis/call_once.cpp
+++
dcoughlin added a comment.
In https://reviews.llvm.org/D39518#914515, @george.karpenkov wrote:
> Updated the diff, addressed review concerns.
> Made it more explicit in comments in tests that we do not crash on libcxx03
> implementation, but that we don't model it either.
>
> @dcoughlin sorry
george.karpenkov updated this revision to Diff 121371.
george.karpenkov added a comment.
Updated the diff, addressed review concerns.
Made it more explicit in comments in tests that we do not crash on libcxx03
implementation, but that we don't model it either.
@dcoughlin sorry I disagree on
xazax.hun added inline comments.
Comment at: lib/Analysis/BodyFarm.cpp:415
CallbackRecordDecl, CallArgs);
- } else {
+ } else if (Callback->getType()->isRValueReferenceType()
+ ||
george.karpenkov created this revision.
Herald added a reviewer: EricWF.
Herald added subscribers: szepet, xazax.hun, javed.absar.
Addresses https://bugs.llvm.org/show_bug.cgi?id=35075
https://reviews.llvm.org/D39518
Files:
lib/Analysis/BodyFarm.cpp
test/Analysis/call_once.cpp
Index:
