[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

2017-11-02 Thread George Karpenkov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317294: [analyzer] [NFC] very minor ExprEngineC refactoring (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39577?vs=121401=121424#toc Repository: rL LLVM

[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

2017-11-02 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. @dcoughlin thanks for accepting quickly, actually the whole file has a very large amount of duplicated code, but I guess we can't do it right now. https://reviews.llvm.org/D39577 ___ cfe-commits mailing list

[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

2017-11-02 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. It is a nice cleanup. https://reviews.llvm.org/D39577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

2017-11-02 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun. https://reviews.llvm.org/D39577 Files: lib/StaticAnalyzer/Core/ExprEngineC.cpp Index: lib/StaticAnalyzer/Core/ExprEngineC.cpp === ---