This revision was automatically updated to reflect the committed changes.
Closed by commit rL317849: [analyzer] [NFC] Minor ExprEngineC refactoring
(authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39584?vs=121814=122345#toc
Repository:
rL LLVM
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Yes, looks great. Thanks!
https://reviews.llvm.org/D39584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
george.karpenkov added a comment.
@dcoughlin OK to commit?
https://reviews.llvm.org/D39584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov updated this revision to Diff 121814.
george.karpenkov edited the summary of this revision.
george.karpenkov added a comment.
Addressed review comments.
https://reviews.llvm.org/D39584
Files:
lib/StaticAnalyzer/Core/ExprEngineC.cpp
Index:
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:26
+/// results in an ElementRegion.
+static void conjureOffsetSymbolOnLocation(
+SVal , SVal Other, Expr* Expression, SValBuilder ,
I think it would be more clear at the
george.karpenkov created this revision.
Herald added subscribers: szepet, xazax.hun.
couldn't resist adding a function here.
I think this would be the last one.
https://reviews.llvm.org/D39584
Files:
lib/StaticAnalyzer/Core/ExprEngineC.cpp
Index: lib/StaticAnalyzer/Core/ExprEngineC.cpp
