NoQ added a comment.
Sorry, i wanted to quickly look at why this thing is lvalue, but this didn't
seem to be happening, so i guess i'd just commit for now.
Repository:
rL LLVM
https://reviews.llvm.org/D39800
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319055: [analyzer] pr34404: Fix a crash on modeling pointers
to indirect members. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D39800?vs=122087=124404#toc
Repository:
alexfh added a comment.
Is anything holding this patch?
https://reviews.llvm.org/D39800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun accepted this revision.
xazax.hun added a comment.
LGTM!
https://reviews.llvm.org/D39800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
LGTM.
I suppose we could move the logic that constructs pointers to members for
fields here (right now that logic is in ExprEngine::VisitUnaryOperator()'s
handling of '&'). However, since the AST's DeclRefExpr for the field is marked
kromanenkov added a comment.
@NoQ Do we need to change a `DeclaratorDecl` field in PointerToMember SVal to
something more common, like `ValueDecl`, to support `IndirectFieldDecl` as well?
https://reviews.llvm.org/D39800
___
cfe-commits mailing
NoQ created this revision.
pr34404 points out that given
class C {
struct {
int x;
};
};
, taking pointer-to-member `::x` would crash the analyzer. We were not ready
to stumble upon an `IndirectFieldDecl`, which is used for representing a field
within an anonymous structure
