smeenai added a comment.
It wasn't automatically closed because the commit
(https://reviews.llvm.org/rL317960) referenced the wrong differential in its
Differential Revision field. Not sure how that happened.
Repository:
rL LLVM
https://reviews.llvm.org/D39821
___
jakehehrlich closed this revision.
jakehehrlich added a comment.
This has already landed, I'm not sure why it wasn't automatically closed.
Repository:
rL LLVM
https://reviews.llvm.org/D39821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jakehehrlich added a comment.
> Another option would be to restrict `CLANG_DEFAULT_OBJCOPY` to contain
> `objcopy` or even to only allow `objcopy` or `llvm-objcopy`. I don't know if
> that's sensible though...
I think there are some other strip/objcopy like implementations out there but I
thin
Hahnfeld added a comment.
In https://reviews.llvm.org/D39821#922026, @jakehehrlich wrote:
> In https://reviews.llvm.org/D39821#921703, @Hahnfeld wrote:
>
> > I think the current tests will only pass iff the executable name ends with
> > `objcopy` - can we make this more reliable?
>
>
> If I read
jakehehrlich added a comment.
In https://reviews.llvm.org/D39821#921703, @Hahnfeld wrote:
> I think the current tests will only pass iff the executable name ends with
> `objcopy` - can we make this more reliable?
If I read the tests (split-debug.h, split-debug.c, and split-debug.s) correctly
Hahnfeld added a comment.
I think the current tests will only pass iff the executable name ends with
`objcopy` - can we make this more reliable?
Repository:
rL LLVM
https://reviews.llvm.org/D39821
___
cfe-commits mailing list
cfe-commits@lists.l
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D39821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
jakehehrlich updated this revision to Diff 122382.
jakehehrlich added a comment.
fixed typo
Repository:
rL LLVM
https://reviews.llvm.org/D39821
Files:
CMakeLists.txt
include/clang/Config/config.h.cmake
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
=
Hahnfeld added inline comments.
Comment at: CMakeLists.txt:236
+set(CLANG_DEFAULT_OBJCOPY "objcopy" CACHE STRING
+ "Default objcopy runtime to use.")
+
Nit: `runtime` -> `executable`
https://reviews.llvm.org/D39821
__
jakehehrlich created this revision.
Herald added subscribers: aprantl, mgorny.
llvm-objcopy is getting to where it can be used in non-trivial ways (such as
for dwarf fission in clang). It now supports dwarf fission but this feature
hasn't been thoroughly tested yet. This change allows people to
10 matches
Mail list logo
