NoQ added a comment.
In https://reviews.llvm.org/D39862#921075, @george.karpenkov wrote:
> Of course I'm new, but I disagree with this statement: in order to have a
> robust API, the function should not crash, unless the caller violates an
> explicit precondition.
> `getSVal` is just a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317839: [analyzer] do not crash when trying to convert an
APSInt to an unexpected type (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D39862?vs=122306=122328#toc
NoQ added a comment.
I'm curious if the crash would turn into an assertion failure during
`getRawSVal()` after https://reviews.llvm.org/D38801 is committed.
The problem with this checker producing void symbols is known since
https://reviews.llvm.org/D26837. If this problem is fixed on the
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This seems reasonable to me. Please commit it. @NoQ can do a post-commit review
and fix it up if he would rather address the issue differently.
https://reviews.llvm.org/D39862
george.karpenkov created this revision.
Herald added subscribers: szepet, xazax.hun.
This is the issue breaking the postgresql bot, purely by chance exposed through
taint checker, somehow appearing after https://reviews.llvm.org/D38358 got
committed.
The backstory is that the taint checker
