This revision was automatically updated to reflect the committed changes.
Closed by commit rL318366: add check to avoid throwing objc exception according
to Google Objective-C guide (authored by Wizard).
Repository:
rL LLVM
https://reviews.llvm.org/D40058
Files:
benhamilton accepted this revision.
benhamilton added a comment.
LGTM
https://reviews.llvm.org/D40058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Wizard updated this revision to Diff 123093.
Wizard added a comment.
nit fix
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjCExceptionCheck.h
clang-tidy/google/CMakeLists.txt
benhamilton added a comment.
File names look good now, thanks.
Comment at: clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp:1
+//===--- AvoidThrowingObjcExceptionCheck.cpp -
clang-tidy--===//
+//
Objc -> ObjC
Wizard updated this revision to Diff 123091.
Wizard marked an inline comment as done.
Wizard added a comment.
rename again
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjCExceptionCheck.h
Wizard updated this revision to Diff 123090.
Wizard marked 6 inline comments as done.
Wizard added a comment.
rename file
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjC2ExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjC2ExceptionCheck.h
Wizard updated this revision to Diff 123089.
Wizard marked 2 inline comments as done.
Wizard added a comment.
address comments
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjcExceptionCheck.h
benhamilton added inline comments.
Comment at: clang-tidy/google/AvoidThrowingObjcExceptionCheck.h:1
+//===--- AvoidThrowingObjCExceptionCheck.h - clang-tidy--*- C++
-*-===//
+//
benhamilton wrote:
> Don't forget to rename the file to
benhamilton added inline comments.
Comment at: test/clang-tidy/google-objc-avoid-throwing-exception.m:17-20
+- (void)f2 {
+[NSException raise:@"TestException" format:@"Test"];
+// CHECK-MESSAGES: :[[@LINE-1]]:18: warning: pass in NSError ** instead of
throwing exception
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
Looking good. Please rename the files correctly, or it will not build on Linux.
Comment at: clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp:23
+
Wizard updated this revision to Diff 123079.
Wizard marked 10 inline comments as done.
Wizard added a comment.
address comments
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjcExceptionCheck.h
hokein added inline comments.
Comment at: clang-tidy/google/AvoidThrowingObjcExceptionCheck.h:1
+//===--- AvoidThrowingObjcExceptionCheck.h - clang-tidy--*- C++
-*-===//
+//
benhamilton wrote:
> Naming nit-pick: We are currently using `ObjC`, not
benhamilton requested changes to this revision.
benhamilton added a comment.
This revision now requires changes to proceed.
Almost there.
Comment at: clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp:22
+void AvoidThrowingObjcExceptionCheck::registerMatchers(MatchFinder
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with a few nits, I'd like to see whether @benhamilton has comments before
committing it.
Comment at: docs/clang-tidy/checks/google-objc-avoid-throwing-exception.rst:4
Wizard updated this revision to Diff 122953.
Wizard added a comment.
new line
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjcExceptionCheck.h
clang-tidy/google/CMakeLists.txt
15 matches
Mail list logo
