peter.smith added a comment.
In https://reviews.llvm.org/D40127#929578, @compnerd wrote:
> Would be nice to rename the variable prior to commit.
Thanks for the review, I've renamed the variable as suggested.
https://reviews.llvm.org/D40127
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318647: [ARM] For assembler files recognize -Xassembler or
-Wa, -mthumb (authored by psmith).
Changed prior to commit:
https://reviews.llvm.org/D40127?vs=123310=123571#toc
Repository:
rL LLVM
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Would be nice to rename the variable prior to commit.
Comment at: lib/Driver/ToolChain.cpp:549-556
+bool IsIntegratedAssemblerThumb = false;
+for (const Arg *A :
peter.smith updated this revision to Diff 123310.
peter.smith added a comment.
Updated diff with an attempt to simplify the check for filetype and mthumb.
I've left the existing Args.filtered in expression for now as I couldn't make a
better alternative with std::for_any.
peter.smith added inline comments.
Comment at: lib/Driver/ToolChain.cpp:549-556
+bool IsIntegratedAssemblerThumb = false;
+for (const Arg *A :
+ Args.filtered(options::OPT_Wa_COMMA, options::OPT_Xassembler)) {
+ for (StringRef Value : A->getValues()) {
+
compnerd added inline comments.
Comment at: lib/Driver/ToolChain.cpp:549-556
+bool IsIntegratedAssemblerThumb = false;
+for (const Arg *A :
+ Args.filtered(options::OPT_Wa_COMMA, options::OPT_Xassembler)) {
+ for (StringRef Value : A->getValues()) {
+
peter.smith created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
The Unified Arm Assembler Language is designed so that the majority of
assembler files can be assembled for both Arm and Thumb with the choice made as
a compilation option. The way this is done in
