[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

ldionne abandoned this revision. ldionne added a comment. Closing as this is superseded by D92725 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40259/new/ https://reviews.llvm.org/D40259

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

ldionne commandeered this revision. ldionne added a reviewer: K-ballo. ldionne added a comment. Herald added a subscriber: jkorous. This is superseded by D92725 , so I'm going to commandeer and abandon this to clear up the review queue. Thanks for your

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

mclow.lists added a comment. Did this ever get landed? If not, was there a reason? Note that the synopsis at the top of `` also needs to be updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40259/new/ https://reviews.llvm.org/D40259

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

mclow.lists accepted this revision. mclow.lists added a comment. Please be sure to update www/cxx2a_status.html to mark 2993 as "Complete". Other than that, looks good to me! Thanks! https://reviews.llvm.org/D40259 ___ cfe-commits mailing list

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after addressing inline comments. Do you have commit access? If not, I'll commit once updated. Comment at:

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

K-ballo updated this revision to Diff 124005. K-ballo added a comment. Back to `decltype`-based SFINAE. https://reviews.llvm.org/D40259 Files: include/__functional_base include/functional test/std/utilities/function.objects/refwrap/refwrap.assign/copy_assign.pass.cpp

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF requested changes to this revision. EricWF added inline comments. This revision now requires changes to proceed. Comment at: include/__functional_base:396 +!is_same<__uncvref_t<_Up>, reference_wrapper>::value +>::type, bool _IsNothrow =

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

K-ballo updated this revision to Diff 123813. K-ballo added a comment. Full context diff. https://reviews.llvm.org/D40259 Files: include/__functional_base include/functional test/std/utilities/function.objects/refwrap/refwrap.assign/copy_assign.pass.cpp

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF added inline comments. Comment at: include/__functional_base:396 +!is_same<__uncvref_t<_Up>, reference_wrapper>::value +>::type, bool _IsNothrow = noexcept(__bind(_VSTD::declval<_Up>()))> +_LIBCPP_INLINE_VISIBILITY reference_wrapper(_Up&& __u)

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

tcanens added inline comments. Comment at: include/__functional_base:396 +!is_same<__uncvref_t<_Up>, reference_wrapper>::value +>::type, bool _IsNothrow = noexcept(__bind(_VSTD::declval<_Up>()))> +_LIBCPP_INLINE_VISIBILITY reference_wrapper(_Up&& __u)

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF added inline comments. Comment at: include/__functional_base:396 +!is_same<__uncvref_t<_Up>, reference_wrapper>::value +>::type, bool _IsNothrow = noexcept(__bind(_VSTD::declval<_Up>()))> +_LIBCPP_INLINE_VISIBILITY reference_wrapper(_Up&& __u)

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

tcanens added inline comments. Comment at: include/__functional_base:396 +!is_same<__uncvref_t<_Up>, reference_wrapper>::value +>::type, bool _IsNothrow = noexcept(__bind(_VSTD::declval<_Up>()))> +_LIBCPP_INLINE_VISIBILITY reference_wrapper(_Up&& __u)

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

K-ballo updated this revision to Diff 123679. K-ballo added a comment. Addressed review comments. Added tests for SFINAE, noexcept, deduction guide. https://reviews.llvm.org/D40259 Files: include/__functional_base include/functional

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

tcanens added inline comments. Comment at: include/__functional_base:377 +inline _LIBCPP_INLINE_VISIBILITY +_Tp& __lvref_bind(_Tp& r) _NOEXCEPT { return r; } + I'd make these member functions of a class template, to avoid having to reason about partial ordering

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF added a comment. Also, you're lacking tests for `noexcept` and the deduction guide. https://reviews.llvm.org/D40259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I would much rather take this change in all dialects except for C++03. Comment at: include/__functional_base:398 +!is_same<__uncvref_t<_Up>,

[PATCH] D40259: [libcxx] LWG2993: reference_wrapper conversion from T&

K-ballo created this revision. Implement LWG2993, `reference_wrapper` conversion from `T&&`. The conversion fail test currently fails to fail (passes), due to https://bugs.llvm.org/show_bug.cgi?id=35332. Flagging it `XFAIL` does not seem to have any effect. https://reviews.llvm.org/D40259