[PATCH] D40478: Added Instrument Control Flow Flag

2017-12-14 Thread Oren Ben Simhon via Phabricator via cfe-commits
oren_ben_simhon updated this revision to Diff 127008. oren_ben_simhon added a comment. Implemented all comments posted until 12/14 (Thanks Peter) Repository: rL LLVM https://reviews.llvm.org/D40478 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

[PATCH] D40478: Added Instrument Control Flow Flag

2017-12-13 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: include/clang/Driver/Options.td:1035 HelpText<"Instrument function entry only, after inlining, without arguments to the instrumentation call">; - +def finstrument_control_flow : Flag<["-"], "finstrument-control-flow">, +

[PATCH] D40478: Added Instrument Control Flow Flag

2017-12-13 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added inline comments. Comment at: include/clang/Driver/Options.td:1035 HelpText<"Instrument function entry only, after inlining, without arguments to the instrumentation call">; - +def finstrument_control_flow : Flag<["-"], "finstrument-control-flow">, + Group,

[PATCH] D40478: Added Instrument Control Flow Flag

2017-12-13 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. -mibt isn't required for inline assembly, There's no AssemblePredicate defined with HasIBT in X86InstrInfo.td. We don't normally do fine grained assembler feature enabling so I believe we should always support it. Repository: rL LLVM